util: add internal assignFunctionName() function

[LiviaMedeiros]

Extracted from: #57901

We have a lot of functions exposed to userspace or mentioned in stack traces that are anonymous or have something inherited like value as name; because it's not convenient to define it with name, or because the correct name is already taken by another variable, or because the name comes from a Symbol, or because of false positives from linter.

This helper function will simplify giving such functions a correct name.

[BridgeAR]

I think it's best to introduce the helper in the other PR, since it is used that way.

[LiviaMedeiros]

I extracted this so it could be used for other namings (e.g. for some [Symbol(nodejs.util.promisify.custom)] functions), since it's not related to the other PR, doesn't have to depend on it, and would simplify the process (especially for backports and cherry-picking later). But it's feasible either way.

[BridgeAR]

I would definitely like adding usages right away. It would otherwise feel weird to me to add a utility function for internal usage only. We could of course split it into two commits in the same PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (609df89) to head (5292de9).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57916      +/-   ##
==========================================
- Coverage   90.27%   90.27%   -0.01%     
==========================================
  Files         630      630              
  Lines      186112   186145      +33     
  Branches    36464    36471       +7     
==========================================
+ Hits       168013   168042      +29     
+ Misses      10981    10970      -11     
- Partials     7118     7133      +15     

Files with missing lines	Coverage Δ
lib/child_process.js	97.75% <100.00%> (+<0.01%)	⬆️
lib/internal/http2/core.js	95.63% <100.00%> (+<0.01%)	⬆️
lib/internal/util.js	96.30% <100.00%> (+0.56%)	⬆️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[H4ad]

Should this be marked as minor since we change the behavior a little bit (although it's not disrupting)?

[aduh95]

If we change the semverness of this PR, we should definitely split it in several PRs to simplify work for releasers

[LiviaMedeiros]

Should this be marked as minor since we change the behavior a little bit (although it's not disrupting)?

I'm okay with semverness change if needed, but not sure it can be semver-minor, since it doesn't add any userland-facing features. IMHO the helper function by itself is semver-patch, and the other changes are either semver-patch fixes or semver-major (potentially) breaking fixes.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66372/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66381/