fix(build): set commonjs option to false in rollup configuration

[productdevbook]

🔗 Linked issue

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/module-builder@599

commit: af70e08

[danielroe]

would you explain what problem this solves?

[productdevbook]

remove d.cts

[danielroe]

Would you please provide a reproduction? 🙏 .d.cts files are not emitted in the module playground in example/

[productdevbook]

this example, That's where the problem is. I've already tested it here

my node: v23.10.0

[danielroe]

would you provide a runnable reproduction, such as stackblitz?

screenshots don't help pinpoint an issue

[productdevbook]

this same library, Am I writing it wrong, that's the problem :D, https://github.com/nuxt/module-builder/tree/main/example

[danielroe]

seems fine: https://stackblitz.com/edit/github-nscnka7b

[productdevbook]

stack: node -v
v20.19.0

my v23.10.0

[danielroe]

please provide a runnable reproduction or steps as to how to reproduce 🙏

I have taken the trouble to create a stackblitz to investigate - try modifying it or updating the startCommand so it reproduces...

[productdevbook]

Very interestingly, it's happening now. I've created the example several times since this morning.