Block update when instance is provisioned #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge-platform/infra-core into block-lc-instance-update
pierventre
reviewed
Apr 2, 2025
pierventre
reviewed
Apr 2, 2025
pierventre
reviewed
Apr 2, 2025
There was a problem hiding this comment.
do a test case without field in the fm as well
There was a problem hiding this comment.
please do this as well - to avoid future surprise
pierventre
reviewed
Apr 3, 2025
inventory/internal/store/instance.go
Outdated
| // transition from Untrusted to any other state than DELETED is not allowed | ||
| return slices.Contains(fieldmask.GetPaths(), instanceresource.FieldDesiredState) && | ||
| instanceq.CurrentState == instanceresource.CurrentStateINSTANCE_STATE_UNTRUSTED && | ||
| in.DesiredState != computev1.InstanceState_INSTANCE_STATE_DELETED | ||
| in.DesiredState != computev1.InstanceState_INSTANCE_STATE_DELETED || |
There was a problem hiding this comment.
my suggestion was to borrow the logic (and create a similar function) that check if
slices.Contains(fieldmask.GetPaths(), instanceresource.FieldCurrentState) AND...
pierventre
reviewed
Apr 3, 2025
inventory/internal/store/instance.go
Outdated
| in.DesiredState != computev1.InstanceState_INSTANCE_STATE_DELETED | ||
| in.DesiredState != computev1.InstanceState_INSTANCE_STATE_DELETED || | ||
| instanceq.CurrentState != instanceresource.CurrentStateINSTANCE_STATE_UNSPECIFIED && | ||
| instanceq.CurrentState != "" && in.GetLocalaccount() != nil |
There was a problem hiding this comment.
Suggested change
| instanceq.CurrentState != "" && in.GetLocalaccount() != nil | |
| && in.GetLocalaccount() != nil |
…ge-platform/infra-core into block-lc-instance-update
pierventre
reviewed
Apr 15, 2025
| in *computev1.InstanceResource, | ||
| ) bool { | ||
| return slices.Contains(fieldmask.GetPaths(), instanceresource.EdgeLocalaccount) && | ||
| in.GetLocalaccount() != nil && |
There was a problem hiding this comment.
I dont believe we need to check if it is not nil
pierventre
reviewed
Apr 15, 2025
| return slices.Contains(fieldmask.GetPaths(), instanceresource.EdgeLocalaccount) && | ||
| in.GetLocalaccount() != nil && | ||
| (instanceq.CurrentState != instanceresource.CurrentStateINSTANCE_STATE_UNSPECIFIED && | ||
| len(instanceq.CurrentState) != 0) |
There was a problem hiding this comment.
why do we need len check?
pierventre
reviewed
Apr 15, 2025
| }, | ||
| "UpdateInstanceLocalAccount": { | ||
| "UpdateInstanceDetailStatus": { |
There was a problem hiding this comment.
what is this change about ?
pierventre
reviewed
Apr 15, 2025
Paiadhithi
requested review from
Andrea-Campanella,
cjnolan and
damiankopyto
as code owners
Paiadhithi
requested review from
daniele-moro,
ikyrycho,
jkossak,
ktaube26,
osinstom,
Paiadhithi,
PalashGoelIntel,
raphaelvrosa,
rranjan3,
soniabha-intc,
sunil-parida,
tmatenko and
zdw
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL DESCRIPTION
Provide a 1-2 line brief overview of the changes submitted through the Pull Request...
Impact Analysis
CODE MAINTAINABILITY
Code must act as a teacher for future developers