Instrument the OTel trace API's auto SDK #2001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
force-pushed
the
nonrecording-trace-api-sdk
branch
2 times, most recently
from
2f5c92a to
d650cf5
Compare
MrAlias
force-pushed
the
nonrecording-trace-api-sdk
branch
4 times, most recently
from
2ea1657 to
0933d79
Compare
RonFed
reviewed
Mar 21, 2025
There was a problem hiding this comment.
overall, looks great.
wonder if we can share a lot of this between the auto/sdk probe and this new one in:
- C code - we can have a common header with the common functionality.
probe.goalso has common logic of parsing the perf events.- e2e tests can be unified.
internal/pkg/instrumentation/bpf/go.opentelemetry.io/otel/trace/bpf/probe.bpf.c
Show resolved
Hide resolved
internal/pkg/instrumentation/bpf/go.opentelemetry.io/otel/trace/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
MrAlias
force-pushed
the
nonrecording-trace-api-sdk
branch
2 times, most recently
from
8157934 to
321bdf7
Compare
MrAlias
force-pushed
the
nonrecording-trace-api-sdk
branch
2 times, most recently
from
5849065 to
91dfbbd
Compare
MrAlias
force-pushed
the
nonrecording-trace-api-sdk
branch
4 times, most recently
from
a224cc2 to
38e36a9
Compare
RonFed
approved these changes
Apr 19, 2025
MrAlias
force-pushed
the
nonrecording-trace-api-sdk
branch
from
28ab7f5 to
c4043c1
Compare
Unify SDK probe decls in header
MrAlias
force-pushed
the
nonrecording-trace-api-sdk
branch
from
c4043c1 to
50ebe32
Compare
The semver comparison will not match if the prerelease is empty for one version while non-empty for the other. Add a "0" to the prerelease in the traceglobal versions to correctly compare versions and get the expected behavior.
github-project-automation
bot
moved this from In progress
to Done
in Go Auto Instrumentation: GA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #974
Depends on open-telemetry/opentelemetry-go#6456.