-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8354556: Expand value-based class warnings to java.lang.ref API #24746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8354556: Expand value-based class warnings to java.lang.ref API #24746
Conversation
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@vicente-romero-oracle The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add handling of RequiresIdentity
in createAnnotation
@@ -4249,6 +4249,14 @@ compiler.warn.declared.using.preview=\ | |||
compiler.warn.attempt.to.synchronize.on.instance.of.value.based.class=\ | |||
attempt to synchronize on an instance of a value-based class | |||
|
|||
# lint: identity | |||
compiler.warn.attempt.to.synchronize.on.instance.of.value.based.class2=\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this different from the message with no 2 suffix? Is there a reason why one localization entry is required for one type of lint?
Progress
Error
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24746/head:pull/24746
$ git checkout pull/24746
Update a local copy of the PR:
$ git checkout pull/24746
$ git pull https://git.openjdk.org/jdk.git pull/24746/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24746
View PR using the GUI difftool:
$ git pr show -t 24746
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24746.diff