Skip to content

8354556: Expand value-based class warnings to java.lang.ref API #24746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Apr 18, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ The pull request body must not be empty.

Issue

  • JDK-8354556: Expand value-based class warnings to java.lang.ref API (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24746/head:pull/24746
$ git checkout pull/24746

Update a local copy of the PR:
$ git checkout pull/24746
$ git pull https://git.openjdk.org/jdk.git pull/24746/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24746

View PR using the GUI difftool:
$ git pr show -t 24746

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24746.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2025

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@vicente-romero-oracle The following labels will be automatically applied to this pull request:

  • build
  • compiler
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add handling of RequiresIdentity in createAnnotation

@@ -4249,6 +4249,14 @@ compiler.warn.declared.using.preview=\
compiler.warn.attempt.to.synchronize.on.instance.of.value.based.class=\
attempt to synchronize on an instance of a value-based class

# lint: identity
compiler.warn.attempt.to.synchronize.on.instance.of.value.based.class2=\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from the message with no 2 suffix? Is there a reason why one localization entry is required for one type of lint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants