Skip to content

8354928: Clean up and open source some miscellaneous AWT tests #24755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

azuev-java
Copy link
Member

@azuev-java azuev-java commented Apr 18, 2025

Clean up and open source some tests related to event processing in AWT library.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8354928: Clean up and open source some miscellaneous AWT tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24755/head:pull/24755
$ git checkout pull/24755

Update a local copy of the PR:
$ git checkout pull/24755
$ git pull https://git.openjdk.org/jdk.git pull/24755/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24755

View PR using the GUI difftool:
$ git pr show -t 24755

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24755.diff

Using Webrev

Link to Webrev Comment

Clean up and open source some tests related to event peocessing in AWT library.
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2025

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354928: Clean up and open source some miscellaneous AWT tests

Reviewed-by: prr, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 517 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2025
@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@azuev-java The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 18, 2025

Webrevs

@DamonGuy
Copy link
Contributor

The rest of the tests (automated and manual) run as expected and pass on my end.

azuev-java and others added 2 commits April 18, 2025 13:06
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 22, 2025
@azuev-java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 22, 2025

Going to push as commit 1b8f760.
Since your change was applied there have been 518 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 22, 2025
@openjdk openjdk bot closed this Apr 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2025
@openjdk
Copy link

openjdk bot commented Apr 22, 2025

@azuev-java Pushed as commit 1b8f760.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants