Skip to content

feat: add CSS file reference for local styled share module #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imyangyong
Copy link
Contributor

@imyangyong imyangyong commented Apr 18, 2025

Description

When cssCodeSplit is enabled, locally styled shared modules should handle their own CSS imports. Currently, these imports are being omitted in the federated output.

Example:

  1. Host configuration (vite.config.ts):
shared: {
   'shared-styled': {}
}
  1. Styled shared module source code:
import './style.css'
// module implementation...
  1. Current output __federation_shared_shared-styled-{8}.js:
// module code without the CSS import...

Solution:
This PR ensures CSS imports are properly included in the federated output:

import './xxx.css';  // CSS imported
// module code...

Testing
To verify the feature:
pnpm run test:e2e-serve shared-styled

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Code of Conduct and follow the Commit Convention guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant