Skip to content

feat(linter): add eslint/block-scoped-var #10237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

huangtiandi1999
Copy link
Contributor

Copy link

graphite-app bot commented Apr 4, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@huangtiandi1999 huangtiandi1999 marked this pull request as draft April 4, 2025 15:22
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Apr 4, 2025
Copy link

codspeed-hq bot commented Apr 4, 2025

CodSpeed Instrumentation Performance Report

Merging #10237 will degrade performances by 3.1%

Comparing huangtiandi1999:feat/linter/block-scoped-var (901c20e) with main (c290faa)

Summary

❌ 1 regressions
✅ 35 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
linter[checker.ts] 3 s 3.1 s -3.1%

@huangtiandi1999 huangtiandi1999 marked this pull request as ready for review April 6, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant