Skip to content

fix(parser,linter): consider typescript declarations for named exports #10532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ulrichstark
Copy link
Contributor

@ulrichstark ulrichstark commented Apr 21, 2025

Only VariableDeclaration, FunctionDeclaration and ClassDeclaration were considered when collecting named export declarations for the module record. Now the parser also considers TSTypeAliasDeclaration, TSInterfaceDeclaration, TSEnumDeclaration, TSImportEqualsDeclaration and TSModuleDeclaration named export declarations of the module.

Maybe the other decl.declaration.is_typescript_syntax() check in module_record.rs also needs to be removed?

Closes #10318
Closes #10556

Copy link

graphite-app bot commented Apr 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser C-bug Category - Bug labels Apr 21, 2025
Copy link

codspeed-hq bot commented Apr 21, 2025

CodSpeed Instrumentation Performance Report

Merging #10532 will not alter performance

Comparing ulrichstark:fix-missing-named-exports-of-typescript-declarations (578af74) with main (3fafc0d)

Summary

✅ 36 untouched benchmarks

@ulrichstark ulrichstark changed the title fix(parser,linter): consider named exports of typescript declarations fix(parser,linter): consider typescript declarations for named exports Apr 21, 2025
@Boshen Boshen self-requested a review April 22, 2025 01:58
@Boshen
Copy link
Member

Boshen commented Apr 22, 2025

I'll need to recall the reason for skipping typescript declarations (including merge declarations).

@ulrichstark ulrichstark force-pushed the fix-missing-named-exports-of-typescript-declarations branch from 743329a to 578af74 Compare April 24, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter A-parser Area - Parser C-bug Category - Bug
Projects
None yet
2 participants