configuration: Add support for Envoys MaxStreamDuration configuration

[nickburgin]

Fixes #6873

Signed-off-by: Nick Burgin [email protected]

[github-actions]

Hi @nickburgin! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

[nickburgin]

I wasn't able to add labels, but this should be considered release-note/small unless one of the maintainers thinks it should be a minor (In which case, I will need to change the release notes entry)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.79%. Comparing base (39c7cb9) to head (18151c3).
Report is 51 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6895      +/-   ##
==========================================
+ Coverage   80.70%   80.79%   +0.09%     
==========================================
  Files         131      131              
  Lines       19805    19828      +23     
==========================================
+ Hits        15983    16021      +38     
+ Misses       3532     3522      -10     
+ Partials      290      285       -5     

Files with missing lines	Coverage Δ
cmd/contour/servecontext.go	87.77% <100.00%> (+3.43%)	⬆️
internal/contourconfig/contourconfiguration.go	98.23% <100.00%> (+0.06%)	⬆️
internal/dag/dag.go	98.78% <ø> (ø)
internal/dag/policy.go	95.72% <100.00%> (+0.04%)	⬆️
internal/envoy/v3/route.go	80.53% <100.00%> (+0.11%)	⬆️
pkg/config/parameters.go	87.76% <100.00%> (+0.11%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nickburgin]

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

...

There were no tests for any of the timeout settings. I have added a basic test case for those to ensure they are all passed through as expected.

[tsaarni]

Hi @nickburgin, thanks for the PR!

It looks like global config support isn't fully working yet. MaxStreamDuration needs to be connected to HTTPConnectionManagerBuilder. See how max connection duration was previously hooked here, here and here + tests.

For documentation, it would be great to add a bullet point here and update the config file documentation.

[github-actions]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

[github-actions]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

[github-actions]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack