Move default Vela/Regor configurations to Sram_Only #10279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10279
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 3 Unrelated FailuresAs of commit 87434e3 with merge base 06f912d ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73212758 |
|
@pytorchbot label "topic: not user facing" |
3l1
added a commit
to 3l1/executorch
that referenced
this pull request
Apr 21, 2025
Summary: Move default Vela/Regor configurations to Sram_Only Differential Revision: D73212758
Summary: Pull Request resolved: pytorch#10279 Move default Vela/Regor configurations to Sram_Only Differential Revision: D73212758
|
This pull request was exported from Phabricator. Differential Revision: D73212758 |
digantdesai
reviewed
Apr 21, 2025
| @@ -93,7 +93,7 @@ def get_tosa_compile_spec_unbuilt( | |||
| def get_u55_compile_spec( | |||
| macs: int = 128, | |||
| system_config: str = "Ethos_U55_High_End_Embedded", | |||
| memory_mode: str = "Shared_Sram", | |||
| memory_mode: str = "Sram_Only", | |||
There was a problem hiding this comment.
what is the rationale for changing the default? I don't see any issues, asking because I am not sure why this was the default before.
cc @freddan80, @zingo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Move default Vela/Regor configurations to Sram_Only
Differential Revision: D73212758