Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[not yet for review] migrate pt2e from torch.ao to torchao #10294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[not yet for review] migrate pt2e from torch.ao to torchao #10294
Changes from all commits
daadb76
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 38 in backends/arm/quantizer/arm_quantizer.py
MYPY import-untyped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I am wrong but
torchao
isn't a mandetory dep today but now it is?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we define mandatory dependencies? It is installed by the install_requirements script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we pull in source -
executorch/.gitmodules
Line 60 in 647e1f1
So this submodule is already updated since the tests are passing here.
check (1) if we run tests on et wheels with something quant, (2) if we do are they passing for this diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @freddan80 @per
Check failure on line 39 in backends/arm/quantizer/arm_quantizer.py
MYPY import-untyped
Check failure on line 20 in backends/arm/quantizer/arm_quantizer_utils.py
MYPY import-untyped
Check failure on line 17 in backends/arm/quantizer/quantization_annotator.py
MYPY import-untyped
Check failure on line 21 in backends/arm/quantizer/quantization_annotator.py
MYPY import-untyped
Check failure on line 12 in backends/arm/quantizer/quantization_config.py
MYPY import-untyped
Check failure on line 14 in backends/arm/quantizer/quantization_config.py
MYPY import-untyped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @mcremon-meta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @robert-kalmar FYI
Check failure on line 20 in backends/openvino/quantizer/quantizer.py
MYPY import-untyped
Check failure on line 25 in backends/openvino/quantizer/quantizer.py
MYPY import-untyped