Add tests for op_quantize_per_tensor + add checks for quant_min/max #10300
+189
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10300
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 84c894f with merge base c053712 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73268792 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 18, 2025
…ytorch#10300) Summary: HiFi4's quantize_per_tensor does not consider quant_min/max. Add checks when quant_min/max out of bounds. Differential Revision: D73268792
hsharma35
force-pushed
the
export-D73268792
branch
from
3ba8167 to
213c661
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73268792 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 18, 2025
…ytorch#10300) Summary: HiFi4's quantize_per_tensor does not consider quant_min/max. Add checks when quant_min/max out of bounds. Differential Revision: D73268792
hsharma35
force-pushed
the
export-D73268792
branch
from
213c661 to
d97fb9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73268792 |
hsharma35
force-pushed
the
export-D73268792
branch
from
d97fb9b to
366e540
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 19, 2025
…ytorch#10300) Summary: HiFi4's quantize_per_tensor does not consider quant_min/max. Add checks when quant_min/max out of bounds. Reviewed By: mcremon-meta Differential Revision: D73268792
|
This pull request was exported from Phabricator. Differential Revision: D73268792 |
mcremon-meta
approved these changes
Apr 19, 2025
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 21, 2025
…ytorch#10300) Summary: HiFi4's quantize_per_tensor does not consider quant_min/max. Add checks when quant_min/max out of bounds. Reviewed By: mcremon-meta Differential Revision: D73268792
hsharma35
force-pushed
the
export-D73268792
branch
from
366e540 to
dcff8c2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73268792 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Apr 21, 2025
…ytorch#10300) Summary: Pull Request resolved: pytorch#10300 HiFi4's quantize_per_tensor does not consider quant_min/max. Add checks when quant_min/max out of bounds. Reviewed By: mcremon-meta Differential Revision: D73268792
hsharma35
force-pushed
the
export-D73268792
branch
from
dcff8c2 to
63a5c55
Compare
…ytorch#10300) Summary: HiFi4's quantize_per_tensor does not consider quant_min/max. Add checks when quant_min/max out of bounds. Reviewed By: mcremon-meta Differential Revision: D73268792
hsharma35
force-pushed
the
export-D73268792
branch
from
63a5c55 to
84c894f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73268792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: HiFi4's quantize_per_tensor does not consider quant_min/max. Add checks when quant_min/max out of bounds.
Differential Revision: D73268792