Reinstate lint infrastructure as GHA #396
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks much cleaner overall.
What automation (if any) do you use to remove lints everywhere? It will be easiest for me to merge a slew of the changes up front, this might take some time. |
MichaelChirico
commented
Mar 16, 2025
Just regex replacement and multicursor mode
OK, take your time. Also happy to split it up if that makes more sense. |
MichaelChirico
commented
Mar 16, 2025
| # @return | ||
| # `dbBind()` returns the result set, | ||
| # invisibly, | ||
| # for queries issued by [dbSendQuery()] or [dbSendQueryArrow()] and | ||
| placeholder_funs <- get_placeholder_funs(ctx) | ||
| is_null_check <- ctx$tweaks$is_null_check | ||
| for (placeholder_fun in placeholder_funs) { | ||
| bind_values <- structure(data.frame(1L, check.names = FALSE), names = "") | ||
| bind_values <- structure(data.frame(1L), names = "") |
There was a problem hiding this comment.
@krlmlr is {constructive} generating these? maybe I need a devel version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started from noticing
test-lint.Ris not really doing anything, and that {lintr} should probably be removed as a package dependency.All changes to package code here are suggestions, I'm happy to revert anything.
Most of the changes are from the
expect*series of linters that recommend "best practices" for {testthat} usage.