Skip to content

Use github's mirror for sourceware's repo #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kito-cheng
Copy link
Collaborator

No description provided.

@TommyMurphyTM1234
Copy link
Collaborator

Hi @kito-cheng - can you clarify what issue this aims to address please?

@kito-cheng
Copy link
Collaborator Author

@TommyMurphyTM1234 oh, yeah, sorry for the empty description, I want to try to fix the shallow clone issue in simpler way, and try to throw a PR to see if CI happy with that fix

@cmuellner
Copy link
Collaborator

Thanks a lot for this, Kito!
That's probably the best way to avoid the unadvertised-commit issue.

We should add a comment in .gitmodules as to why we don't use upstream repos but downstream clones.
Maybe something like this:

Some of the external git repos are not upstream servers but upstream clones to avoid
"Server does not allow request for unadvertised object" errors (see #1654).

@cmuellner
Copy link
Collaborator

ubuntu-24.04, newlib fails with GCC internal compiler errors of the following form:

FAIL: gcc.target/riscv/rvv/autovec/reduc/extract_last-7.c -ftree-vectorize -O3 -mrvv-max-lmul=m8 (internal compiler error: in as_a, at machmode.h:391)

That's clearly unrelated, but we need a fix in a new PR so the CI can successfully terminate.

@TommyMurphyTM1234
Copy link
Collaborator

TommyMurphyTM1234 commented Apr 7, 2025

ubuntu-24.04, newlib fails with GCC internal compiler errors of the following form:

Is this the test suite or something?
I've definitely built the bare-metal Newlib toolchain on Ubuntu 24.04 recently and did hit this problem.
I did have to work around the "shallow clone" issue manually - e.g.:

I'm just going to try it locally again.
My host GCC is 13.3.0 in case that matters?

gcc -v
Using built-in specs.
COLLECT_GCC=/usr/bin/gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-linux-gnu/13/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 13.3.0-6ubuntu2~24.04' --with-bugurl=file:///usr/share/doc/gcc-13/README.Bugs --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-13 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/libexec --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-libstdcxx-backtrace --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-13-fG75Ri/gcc-13-13.3.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-13-fG75Ri/gcc-13-13.3.0/debian/tmp-gcn/usr --enable-offload-defaulted --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu --with-build-config=bootstrap-lto-lean --enable-link-serialization=2
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04)

@cmuellner
Copy link
Collaborator

ubuntu-24.04, newlib fails with GCC internal compiler errors of the following form:

Is this the test suite or something?

Yes, the toolchain build works fine, but there are 584 unexpected failures in the GCC regression test suite, when testing the freshly built toolchain.

@jordancarlin
Copy link
Contributor

Any updates on this? Would be great if the git submodules worked without issue. Any reason this can’t be merged and then fix the tests in a follow up PR since it seems like that’s a separate issue?

@TommyMurphyTM1234
Copy link
Collaborator

Any reason this can’t be merged and then fix the tests in a follow up PR since it seems like that’s a separate issue?

I think that this is the reason.

ubuntu-24.04, newlib fails with GCC internal compiler errors of the following form:

FAIL: gcc.target/riscv/rvv/autovec/reduc/extract_last-7.c -ftree-vectorize -O3 -mrvv-max-lmul=m8 (internal compiler error: in as_a, at machmode.h:391)

That's clearly unrelated, but we need a fix in a new PR so the CI can successfully terminate.

This PR can't be accepted until/unless the CI tests pass and this will not happen until the test suite failures are understood better and addressed via another PR first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants