Update chalk #19624
Open
Update chalk #19624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rust-cloud-vms
bot
force-pushed
the
chalk-update
branch
from
1f0d9d2 to
1504c54
Compare
rust-cloud-vms
bot
force-pushed
the
chalk-update
branch
from
1504c54 to
6daa791
Compare
davidbarsky
approved these changes
Apr 20, 2025
Veykril
requested changes
Apr 21, 2025
There was a problem hiding this comment.
There is a comment at the top of this file that needs to be adjusted now I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of the changes here are switching the order of generics (to be closer to rustc with self generics first).