Skip to content

ENH speed up grad computation via Cython #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

MatthewSZhang
Copy link
Collaborator

Checklist

@MatthewSZhang MatthewSZhang self-assigned this Apr 9, 2025
@MatthewSZhang MatthewSZhang added the enhancement New feature or request label Apr 9, 2025
@MatthewSZhang MatthewSZhang added this to the 0.3.3 milestone Apr 9, 2025
@MatthewSZhang MatthewSZhang linked an issue Apr 9, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (84b2f83) to head (b96534e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          603       582   -21     
=========================================
- Hits           603       582   -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatthewSZhang
Copy link
Collaborator Author

#70 Fix time-narx, time-h, time-eta, nogil-h, and nogil-eta put all code in setup and timing empty

@MatthewSZhang
Copy link
Collaborator Author

On M1 chip, pixi run time-narx outputs

  • 6.3 sec without Cython speedup
  • 1.4 sec with Cython speedup

@MatthewSZhang MatthewSZhang merged commit 820f4e6 into scikit-learn-contrib:main Apr 9, 2025
7 checks passed
@MatthewSZhang MatthewSZhang deleted the narx-cython branch April 9, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT adopt Cython to speed up evaluation of NARX prediction
2 participants