Skip to content

MNT add error that some rows of feat_ids only have -1 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MatthewSZhang
Copy link
Collaborator

Checklist

  • Used a personal fork to propose changes
  • A reference to a related issue: TST check all -1 feat_ids for NARX #74
  • A description of the changes: raise value error when any rows of feat_ids in NARX only have -1

rows of feat_ids only have -1
@MatthewSZhang MatthewSZhang self-assigned this Apr 11, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (84b2f83) to head (4172a64).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #75   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          603       585   -18     
=========================================
- Hits           603       585   -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatthewSZhang MatthewSZhang linked an issue Apr 11, 2025 that may be closed by this pull request
@MatthewSZhang MatthewSZhang merged commit 74dbde9 into scikit-learn-contrib:main Apr 11, 2025
7 checks passed
@MatthewSZhang MatthewSZhang deleted the all-minus-one branch April 11, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST check all -1 feat_ids for NARX
2 participants