Add domain prop, delete cookies with props, misc fixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like this is needed to have sub-dirs installed as well. Also, adjusted README to use pnpm, not npm
Before, cookies were deleted from server without any Set-cookie properties. It resulted in some cookies not being deleted as expected. Now, users control what options should be used for deleting cookies, based on the same inputs (ignoring name, value and expires, of course). This allows to also test how "clear cookie" behaves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great playground project!
I had a lot of fun using it.
I hope these simple fixes will be ok for you.
More changes coming in a future PR 😉
Don't hesitate to have a first look here:
https://github.com/OlivierChirouze/cookies-playground/compare/main...OlivierChirouze:cookies-playground:partitioned?expand=1