Skip to content

femtovg: clamping sim - add a stop at 1.0 on a gradient to match the… #7909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

szecket
Copy link
Member

@szecket szecket commented Mar 21, 2025

… last stop set

linear and radial adjusted

@szecket szecket requested review from tronical and ogoffart March 21, 2025 13:24
@hunger
Copy link
Member

hunger commented Apr 1, 2025

What's up with this one?

.map(|stop| (stop.position, to_femtovg_color(&stop.color)))
.collect();

// Add an extra stop at 1.0 with the same color as the last stop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we only do that if the last stop is smaller than 1.0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants