Support for doctrine/dbal v4 #754
Draft
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems no longer running properly with your changes. jobs no longer start |
|
Yeah, but I wasn't sure why exactly 😅 do you have any idea? I'll try to back to this in couple of days 😉 |
staabm
reviewed
Apr 19, 2025
.github/workflows/tests.yml
Outdated
| @@ -120,7 +144,7 @@ jobs: | |||
| run: composer require sqlftw/sqlftw --ignore-platform-req=php+ | |||
|
|
|||
| - name: Install doctrine/dbal (optional dependency) | |||
| run: composer require doctrine/dbal:^3 --ignore-platform-req=php+ | |||
| run: composer require doctrine/dbal:${{ matrix.dbal-version }} --ignore-platform-req=php+ | |||
There was a problem hiding this comment.
I guess this command now needs to be wrapped into double quotes
staabm
reviewed
Apr 19, 2025
bnowak
force-pushed
the
add-support-for-dbal-v4
branch
from
51deb2d to
f74b52f
Compare
staabm
force-pushed
the
add-support-for-dbal-v4
branch
from
f74b52f to
9a432ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.