feat: prefix a field with %% to use alternate Display
#3258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
requested review from
hawkw,
carllerche,
davidbarsky and
a team
as code owners
michaelbeaumont
force-pushed
the
feat/alternate-display-field
branch
from
d849f38 to
5c6b8f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1311
There's currently no way to use
{:#}to format a field, which is very important foranyhow::Errorin particular.Of course this should be backported v0.1
Solution
Add a new sigil
%%. I had parsing issues with#so I quickly abandoned that, though there may be a way to make it work. I'm not attached to this particular sigil at all.Add a new wrapper similar to
DisplayValuethat formats with the alternate#flag. The solution I have is useformat_args!, this should be OK AFAICT. I think ideally we would use theFormatterAPI to just switch on alternate, but it's nightly only.