-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
fix icon colour issues when in dark mode #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rasmus Örtenholm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AV2VIQbogfNjsAwi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
NYC |
Nice |
Good |
Vooow |
i noticed an issue with the README of this repository, when in dark mode, the icon appears like this:

so i created this PR to fix the issue. now, when in dark mode, using media queries, the icon appears like this:

and when in light mode, it appears in regular black:
