Improve correctness and function declarations #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctness changes:
join
now treats anil
separator as the empty string, rather than the string"nil"
, conforming to the semantics in the README of not convertingnil
to"nil"
.containsp
now automatically returnsnil
if either string input isnil
.alphanump
and similar now use the correct regex checks for multi-line strings, rather than accepting an input if it has any line matching their specification.Optimization changes:
ftype
declarations(time (dotimes (i 100) (with-output-to-string (throwaway) (let ((*standard-output* throwaway)) (asdf:test-system :str)))))
, despite the new tests in this version.constantp
inputs, so performance improvements here derive mainly from the inlining; they do not represent benefits from theftype
declarations in user-code.