Windows Handles: Refactor plugin #1786
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of functionality in this plugin class was using instance methods instead of classmethods; this refactors the plugin to use classmethods instead of instance methods for consistency with the rest of the framework, and bumps the plugin major version to 4.0.0.
This updates the plugins that depend on `Handles` with the correct required version number, as well as calls to the new handles classmethods where needed.
ikelos
reviewed
Apr 26, 2025
| self._type_map = None | ||
| self._cookie = None | ||
| self._level_mask = 7 | ||
| LEVEL_MASK = 7 |
There was a problem hiding this comment.
Can't decide whether this is a constant that other plugins might want to access, or just an internal constant only for use by the plugin? What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of functionality in the
Handlesplugin class was using instance methods instead of classmethods. This refactors the plugin to use classmethods instead of instance methods for consistency with the rest of the framework, and bumps the plugin major version to 4.0.0. It also updates plugins that depend onHandleswith the correct required major version, and converts instances where an instance of the plugin is being constructed to uses of the new classmethods.Also improves some docstrings and type-hinting in
handles.py.