fix[venom]: fix .name invalidation in MakeSSA
#4545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.name` was persisting across runs of MakeSSA, leading to incorrect pass results. this commit moves the `.name` bookkeeping to MakeSSA-internal data structures (`.original_vars`).
fix[test]: make ssa
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4545 +/- ##
==========================================
- Coverage 92.44% 92.44% -0.01%
==========================================
Files 127 127
Lines 18308 18303 -5
Branches 3174 3173 -1
==========================================
- Hits 16925 16920 -5
Misses 946 946
Partials 437 437 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
it doesn't cause any code changes after this
charles-cooper
force-pushed
the
fix/make-ssa-name
branch
from
4d2e574 to
517230a
Compare
harkal
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture