refactor[venom]: extract liveness and cfg data structures #4595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's dead, can always be added to the CFGAnalysis object
charles-cooper
requested review from
harkal and
HodanPlodky
and removed request for
harkal
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4595 +/- ##
==========================================
- Coverage 92.43% 92.43% -0.01%
==========================================
Files 127 127
Lines 18327 18353 +26
Branches 3179 3178 -1
==========================================
+ Hits 16941 16965 +24
Misses 947 947
- Partials 439 441 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HodanPlodky
reviewed
Apr 25, 2025
| @@ -3,19 +3,28 @@ | |||
| from vyper.exceptions import CompilerPanic | |||
| from vyper.utils import OrderedSet | |||
| from vyper.venom.analysis import CFGAnalysis, IRAnalysis | |||
| from vyper.venom.basicblock import IRBasicBlock, IRVariable | |||
| from vyper.venom.basicblock import IRBasicBlock, IRInstruction, IRVariable | |||
|
|
|||
|
|
|||
| class LivenessAnalysis(IRAnalysis): | |||
| """ | |||
| Compute liveness information for each instruction in the function. | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| cfg: CFGAnalysis |
There was a problem hiding this comment.
I more similar things should I create a PR for that quickly
hints for the typecheck
parametrize request_analysis with generics
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| from vyper.codegen.ir_node import IRnode | ||
| from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable | ||
|
|
||
| if TYPE_CHECKING: | ||
| from vyper.venom.context import IRContext |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
harkal
reviewed
Apr 27, 2025
harkal
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture