Skip to content

perf[venom]: improve CSE elimination speed #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

What I did

avoid O(n*k) (n==number of instructions, k==number of available expressions) copies by replacing the dict with a HAMT. HAMT is an immutable dict with O(1) copy (copy by reference), and O(log N) insert/delete/update operations.

also use lru_cache for some Flag operations (which are bizarrely a perf hotspot)

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link

socket-security bot commented Apr 25, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedimmutables@​0.2110010010010080

View full report

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.46%. Comparing base (f2cb6c2) to head (57ffa2c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4607      +/-   ##
==========================================
+ Coverage   92.44%   92.46%   +0.01%     
==========================================
  Files         127      127              
  Lines       18308    18321      +13     
  Branches     3174     3173       -1     
==========================================
+ Hits        16925    16940      +15     
+ Misses        946      945       -1     
+ Partials      437      436       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant