Skip to content

in sdl3 found 2 functions that takes Rect type instead of FRect. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

boyair
Copy link
Contributor

@boyair boyair commented Jan 29, 2025

SDL_RenderFillRect and SDL_RenderRect in SDL3 takes in type SDL_FRect* whereas sdl3.zig function takes on Rect* which is used
with integers. this caused passing this parameter to the function to be read incorrectly and missplace the rectangle based on the bit value of the original integers but presented as floats due to how the SDL3 function reads the data.

…ect as parameter leading to type coercion and misplacing of rectangle.
@hazeycode hazeycode merged commit 749b84f into zig-gamedev:main Jan 31, 2025
1 check passed
@hazeycode
Copy link
Member

Thanks! I'll get everything else updated to 3.2.0 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants