Add --output-on-failure to standalone unit tests.
#5502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rroelke
reviewed
Apr 16, 2025
.github/workflows/unit-test-runs.yml
Outdated
| @@ -80,8 +80,8 @@ jobs: | |||
|
|
|||
| - name: 'Run standalone unit tests' | |||
| run: | | |||
| ctest --test-dir build -R '(^unit_|test_assert)' --no-tests=error | |||
| ctest --test-dir build -R 'test_ci_asserts' | |||
| ctest --test-dir build -R '(^unit_|test_assert)' --no-tests=error --output-on-failure | |||
There was a problem hiding this comment.
We do have some rapidcheck tests in tiledb/common/algorithm/test/unit_parallel_merge.cc where we probably don't want to to this.
Can you add a [rapidcheck] tag to those tests, and then add that as a filter here so we run them separately without printing output?
rroelke
approved these changes
Apr 22, 2025
|
It seems the failure is related to my changes. |
|
I don't think this is needed since we already have the "Print log files (failed build only)" step, which does exactly this. I am suggesting to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--output-on-failureto the "Run standalone unit tests" step so that test failures provide detailed output for easier debugging.TYPE: NO_HISTORY
DESC: This PR adds
--output-on-failureto the "Run standalone unit tests" step so that test failures provide detailed output for easier debugging.