Skip to content

Add --output-on-failure to standalone unit tests. #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+18 −14
Open

Add --output-on-failure to standalone unit tests. #5502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b6d9a9
Add `--output-on-failure` to standalone unit tests.
kounelisagis Apr 16, 2025
9f757c8
Add tags
kounelisagis Apr 22, 2025
7cf6a44
Add filters
kounelisagis Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/unit-test-runs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,12 @@ jobs:

- name: 'Run standalone unit tests'
run: |
ctest --test-dir build -R '(^unit_|test_assert)' --no-tests=error
ctest --test-dir build -R 'test_ci_asserts'
ctest --test-dir build -R '(^unit_|test_assert)' --no-tests=error --output-on-failure "~[rapidcheck]"
# Run rapidcheck tests on their own
ctest --test-dir build -R '(^unit_|test_assert)' --no-tests=error "[rapidcheck]"
ctest --test-dir build -R 'test_ci_asserts' --output-on-failure "~[rapidcheck]"
# Run rapidcheck tests on their own
ctest --test-dir build -R 'test_ci_asserts' "[rapidcheck]"

- name: "Print log files (failed build only)"
run: |
Expand Down
24 changes: 12 additions & 12 deletions tiledb/common/algorithm/test/unit_parallel_merge.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,31 +568,31 @@ void show<VerifyParallelMerge<uint64_t>>(

TEST_CASE(
"parallel merge rapidcheck uint64_t VerifySplitPointStream",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
rc::prop(
"verify_split_point_stream_bounds",
[](VerifySplitPointStream<uint64_t> input) { input.verify(); });
}

TEST_CASE(
"parallel merge rapidcheck uint64_t VerifyIdentifyMergeUnit",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
rc::prop(
"verify_identify_merge_unit",
[](VerifyIdentifyMergeUnit<uint64_t> input) { input.verify(); });
}

TEST_CASE(
"parallel merge rapidcheck uint64_t VerifyTournamentMerge",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
rc::prop(
"verify_tournament_merge",
[](VerifyTournamentMerge<uint64_t> input) { input.verify(); });
}

TEST_CASE(
"parallel merge rapidcheck uint64_t VerifyParallelMerge",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
SECTION("Shrink", "Instances found previously") {
VerifyParallelMerge<uint64_t> instance;

Expand Down Expand Up @@ -1318,31 +1318,31 @@ TEST_CASE(

TEST_CASE(
"parallel merge rapidcheck int8_t VerifySplitPointStream",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
rc::prop(
"verify_split_point_stream_bounds",
[](VerifySplitPointStream<int8_t> input) { input.verify(); });
}

TEST_CASE(
"parallel merge rapidcheck int8_t VerifyIdentifyMergeUnit",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
rc::prop(
"verify_identify_merge_unit",
[](VerifyIdentifyMergeUnit<int8_t> input) { input.verify(); });
}

TEST_CASE(
"parallel merge rapidcheck int8_t VerifyTournamentMerge",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
rc::prop("verify_tournament_merge", [](VerifyTournamentMerge<int8_t> input) {
input.verify();
});
}

TEST_CASE(
"parallel merge rapidcheck int8_t VerifyParallelMerge",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
rc::prop("verify_parallel_merge", [](VerifyParallelMerge<int8_t> input) {
input.verify();
});
Expand Down Expand Up @@ -1370,31 +1370,31 @@ struct Arbitrary<OneDigit> {

TEST_CASE(
"parallel merge rapidcheck OneDigit VerifySplitPointStream",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
rc::prop(
"verify_split_point_stream_bounds",
[](VerifySplitPointStream<OneDigit> input) { input.verify(); });
}

TEST_CASE(
"parallel merge rapidcheck OneDigit VerifyIdentifyMergeUnit",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
rc::prop(
"verify_identify_merge_unit",
[](VerifyIdentifyMergeUnit<OneDigit> input) { input.verify(); });
}

TEST_CASE(
"parallel merge rapidcheck OneDigit VerifyTournamentMerge",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
rc::prop(
"verify_tournament_merge",
[](VerifyTournamentMerge<OneDigit> input) { input.verify(); });
}

TEST_CASE(
"parallel merge rapidcheck OneDigit VerifyParallelMerge",
"[algorithm][parallel_merge]") {
"[algorithm][parallel_merge][rapidcheck]") {
rc::prop("verify_parallel_merge", [](VerifyParallelMerge<OneDigit> input) {
input.verify();
});
Expand Down
Loading