Add configurable preflight status code for CORS middleware #2765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'm adding support to configurable status code for CORS preflight response.
Changes:
middleware/cors.go
:PreflightStatusCode
toCORSConfig
structhttp.NoContent
as default value forPreflightStatusCode
field, keeping the original behaviormiddleware/cors_test.go
TestCORSWithConfig_PreflightStatusCode
with both default and custom status code scenariosAccording do MDN Reference both
200
and204
are allowed, but checking this spec it says any 2XX is an ok status which made me createPreflightStatusCode
as anint
rather than abool
ReturnStatusOkInPreflight
or something like that.