DRIVERS-3162 Add test for SRV hostname validation when resolver and r… #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esolved hostnames are identical with three domain levels
ShaneHarvey
reviewed
Apr 22, 2025
| @@ -48,6 +48,10 @@ For this test, run each of the following cases: | |||
| - the SRV `mongodb+srv://mongo.local` resolving to `test_1.my_hostmongo.local` | |||
| - the SRV `mongodb+srv://blogs.mongodb.com` resolving to `cluster.testmongodb.com` | |||
|
|
|||
| ### 5. Do not throw when return address is identical to SRV hostname and SRV hostname has three or more `.` separated parts | |||
|
|
|||
| - the SRV `mongodb+srv://blogs.mongodb.com` resolving to `blogs.mongodb.com` | |||
There was a problem hiding this comment.
Should we add the case where mongodb+srv://blogs.mongodb.com resolves to test.blogs.mongodb.com? Or is that already tested elsewhere?
There was a problem hiding this comment.
Not sure. We're adding the 5th test because the previous 3 tests confirm that an error is raised. Similar to the first test in which we confirm there is no error, this test confirms there is no error. IIUC, a response of test.blogs.mongodb.com is valid because the domains match, but the hostnames are not identical so we're not looking for this particular success in this test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…esolved hostnames are identical with three domain levels
Please complete the following before merging:
clusters, and serverless).