Skip to content

DRIVERS-3162 Add test for SRV hostname validation when resolver and r… #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DRIVERS-3162 Add test for SRV hostname validation when resolver and r… #1787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/initial-dns-seedlist-discovery/initial-dns-seedlist-discovery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,9 @@ In the future we could consider using the priority and weight fields of the SRV

## ChangeLog

- 2025-04-22: Add test for SRV hostname validation when resolver and resolved hostnames are identical with three domain
levels.

- 2024-09-24: Removed requirement for URI to have three '.' separated parts; these SRVs have stricter parent domain
matching requirements for security. Create terminology section. Remove usage of term `{TLD}`. The `{hostname}` now
refers to the entire hostname, not just the `{subdomain}`.
Expand Down
4 changes: 4 additions & 0 deletions source/initial-dns-seedlist-discovery/tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ For this test, run each of the following cases:
- the SRV `mongodb+srv://mongo.local` resolving to `test_1.my_hostmongo.local`
- the SRV `mongodb+srv://blogs.mongodb.com` resolving to `cluster.testmongodb.com`

### 5. Do not throw when return address is identical to SRV hostname and SRV hostname has three or more `.` separated parts

- the SRV `mongodb+srv://blogs.mongodb.com` resolving to `blogs.mongodb.com`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the case where mongodb+srv://blogs.mongodb.com resolves to test.blogs.mongodb.com? Or is that already tested elsewhere?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. We're adding the 5th test because the previous 3 tests confirm that an error is raised. Similar to the first test in which we confirm there is no error, this test confirms there is no error. IIUC, a response of test.blogs.mongodb.com is valid because the domains match, but the hostnames are not identical so we're not looking for this particular success in this test case.


## Test Setup

The tests in the `replica-set` directory MUST be executed against a three-node replica set on localhost ports 27017,
Expand Down
Loading