8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization

[YaSuenag]

I tried to build OpenJDK with GCC 15.0.1 on Fedora 42 x86_64, however I saw following error.

* For target support_native_java.desktop_libsplashscreen_splashscreen_gif.o:
/home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libsplashscreen/splashscreen_gif.c:51:41: error: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (12 chars into 11 available) [-Werror=unterminated-string-initialization]
   51 | static const char szNetscape20ext[11] = "NETSCAPE2.0";
      | ^~~~~~~~~~~~~
cc1: all warnings being treated as errors

This constant seems to be used to detect Netscape 2.0 extension in GIF image. It should be used to compare with extension block without NUL char, but we should tweak initialization to avoid this error for safety code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24770/head:pull/24770
$ git checkout pull/24770

Update a local copy of the PR:
$ git checkout pull/24770
$ git pull https://git.openjdk.org/jdk.git pull/24770/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24770

View PR using the GUI difftool:
$ git pr show -t 24770

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24770.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (188a709b)