Skip to content

8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization #24770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization #24770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/java.desktop/share/native/libsplashscreen/splashscreen_gif.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -48,7 +48,7 @@
// restore the area overwritten by the graphic with
// what was there prior to rendering the graphic.

static const char szNetscape20ext[11] = "NETSCAPE2.0";
static const char szNetscape20ext[] = "NETSCAPE2.0";

#define NSEXT_LOOP 0x01 // Loop Count field code

Expand Down Expand Up @@ -181,7 +181,7 @@ SplashDecodeGif(Splash * splash, GifFileType * gif)
}
case APPLICATION_EXT_FUNC_CODE:
{
if (size == sizeof(szNetscape20ext)
if (size == strlen(szNetscape20ext)
&& memcmp(pExtension, szNetscape20ext, size) == 0) {
int iSubCode;

Expand Down