Skip to content

refactor(lexer): shorten code for parsing hex digit #10072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Mar 27, 2025

Pure refactor. Shorten code by using ?.

Copy link
Contributor Author

overlookmotel commented Mar 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Mar 27, 2025
@overlookmotel overlookmotel marked this pull request as ready for review March 27, 2025 07:30
Copy link

codspeed-hq bot commented Mar 27, 2025

CodSpeed Instrumentation Performance Report

Merging #10072 will not alter performance

Comparing 03-27-refactor_lexer_shorten_code_for_parsing_hex_digit (630e189) with main (528469e)

Summary

✅ 30 untouched benchmarks
🆕 3 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A

@overlookmotel overlookmotel force-pushed the 03-26-refactor_lexer_remove_unnecessary_line branch from d023335 to 3e825a7 Compare March 27, 2025 07:44
@overlookmotel overlookmotel force-pushed the 03-27-refactor_lexer_shorten_code_for_parsing_hex_digit branch from b349778 to 722b630 Compare March 27, 2025 07:44
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 27, 2025
Copy link

graphite-app bot commented Mar 28, 2025

Merge activity

Pure refactor. Shorten code by using `?`.
@graphite-app graphite-app bot force-pushed the 03-26-refactor_lexer_remove_unnecessary_line branch from 3e825a7 to a24cceb Compare March 28, 2025 04:32
@graphite-app graphite-app bot force-pushed the 03-27-refactor_lexer_shorten_code_for_parsing_hex_digit branch from 722b630 to 630e189 Compare March 28, 2025 04:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025
Base automatically changed from 03-26-refactor_lexer_remove_unnecessary_line to main March 28, 2025 05:01
@graphite-app graphite-app bot merged commit 630e189 into main Mar 28, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 03-27-refactor_lexer_shorten_code_for_parsing_hex_digit branch March 28, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant