-
-
Notifications
You must be signed in to change notification settings - Fork 555
perf(lexer): faster decoding unicode escape sequences #10073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
03-27-perf_lexer_faster_decoding_unicode_escape_sequences
Mar 28, 2025
Merged
perf(lexer): faster decoding unicode escape sequences #10073
graphite-app
merged 1 commit into
main
from
03-27-perf_lexer_faster_decoding_unicode_escape_sequences
Mar 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2025
Merged
b349778
to
722b630
Compare
68f53e0
to
0dd2425
Compare
CodSpeed Instrumentation Performance ReportMerging #10073 will not alter performanceComparing Summary
Benchmarks breakdown
|
Merge activity
|
This was referenced Mar 27, 2025
Tiny optimization to lexer. Use `peek_byte` instead of `peek_char`, and move consuming `{` character in `\u{` to directly after the `peek_byte` call, so that compiler can see that it's infallible and that the next char is definitely ASCII.
722b630
to
630e189
Compare
0dd2425
to
59b855f
Compare
Base automatically changed from
03-27-refactor_lexer_shorten_code_for_parsing_hex_digit
to
main
March 28, 2025 05:06
This was referenced Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-parser
Area - Parser
C-performance
Category - Solution not expected to change functional behavior, only performance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny optimization to lexer.
Use
peek_byte
instead ofpeek_char
, and move consuming{
character in\u{
to directly after thepeek_byte
call, so that compiler can see that it's infallible and that the next char is definitely ASCII.